locker98/postfix_exporter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Making test easier to use

Browse Source
This commit is contained in:
Per Abich 2020-02-22 17:06:44 +01:00
parent 69a7101dc6
commit 0436fed067
1 changed files with 49 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
postfix_exporter_test.go
View File

@ -36,7 +36,8 @@ func TestPostfixExporter_CollectFromLogline(t *testing.T) {
} }
type args struct { type args struct {
line []string line []string
count int removedCount int
saslFailedCount int
} }
tests := []struct { tests := []struct {
name string name string
@ -49,7 +50,12 @@ func TestPostfixExporter_CollectFromLogline(t *testing.T) {
line: []string{ line: []string{
"Feb 11 16:49:24 letterman postfix/qmgr[8204]: AAB4D259B1: removed", "Feb 11 16:49:24 letterman postfix/qmgr[8204]: AAB4D259B1: removed",
}, },
count: 1, removedCount: 1,
saslFailedCount: 0,
},
fields: fields{
qmgrRemoves: &testCounter{count: 0},
unsupportedLogEntries: prometheus.NewCounterVec(prometheus.CounterOpts{}, []string{"process"}),
}, },
}, },
{ {
@ -88,7 +94,28 @@ func TestPostfixExporter_CollectFromLogline(t *testing.T) {
"Feb 11 16:49:27 letterman postfix/qmgr[8204]: D0EEE2596C: removed", "Feb 11 16:49:27 letterman postfix/qmgr[8204]: D0EEE2596C: removed",
"Feb 11 16:49:27 letterman postfix/qmgr[8204]: DFE732172E: removed", "Feb 11 16:49:27 letterman postfix/qmgr[8204]: DFE732172E: removed",
}, },
count: 31, removedCount: 31,
saslFailedCount: 0,
},
fields: fields{
qmgrRemoves: &testCounter{count: 0},
unsupportedLogEntries: prometheus.NewCounterVec(prometheus.CounterOpts{}, []string{"process"}),
},
},
{
name: "SASL Failed",
args: args{
line: []string{
"Apr 26 10:55:19 tcc1 postfix/smtpd[21126]: warning: SASL authentication failure: cannot connect to saslauthd server: Permission denied",
"Apr 26 10:55:19 tcc1 postfix/smtpd[21126]: warning: SASL authentication failure: Password verification failed",
"Apr 26 10:55:19 tcc1 postfix/smtpd[21126]: warning: laptop.local[192.168.1.2]: SASL PLAIN authentication failed: generic failure",
},
saslFailedCount: 1,
removedCount: 0,
},
fields: fields{
smtpdSASLAuthenticationFailures: &testCounter{count: 0},
unsupportedLogEntries: prometheus.NewCounterVec(prometheus.CounterOpts{}, []string{"process"}),
}, },
}, },
} }
@ -119,18 +146,26 @@ func TestPostfixExporter_CollectFromLogline(t *testing.T) {
smtpdTLSConnects: tt.fields.smtpdTLSConnects, smtpdTLSConnects: tt.fields.smtpdTLSConnects,
unsupportedLogEntries: tt.fields.unsupportedLogEntries, unsupportedLogEntries: tt.fields.unsupportedLogEntries,
} }
counter := testCounter{}
e.qmgrRemoves = &counter
for _, line := range tt.args.line { for _, line := range tt.args.line {
e.CollectFromLogLine(line) e.CollectFromLogLine(line)
} }
assert.Equal(t, tt.args.count, counter.Count(), "Wrong number of lines counted") assertCounterEquals(t, e.qmgrRemoves, tt.args.removedCount, "Wrong number of lines counted")
if counter.Count() != tt.args.count { assertCounterEquals(t, e.smtpdSASLAuthenticationFailures, tt.args.saslFailedCount, "Wrong number of Sasl counter counted")
t.Fatal("Counter wrong: ")
}
}) })
} }
} }
func assertCounterEquals(t *testing.T, counter prometheus.Counter, expected int, message string) {
if counter != nil && expected > 0 {
switch counter.(type) {
case *testCounter:
counter := counter.(*testCounter)
assert.Equal(t, expected, counter.Count(), message)
default:
t.Fatal("Type not implemented")
}
}
}
type testCounter struct { type testCounter struct {
count int count int
@ -144,11 +179,11 @@ func (t *testCounter) Count() int {
return t.count return t.count
} }
func (t *testCounter) Add(add float64) { func (t *testCounter) Add(_ float64) {
} }
func (t *testCounter) Collect(c chan<- prometheus.Metric) { func (t *testCounter) Collect(_ chan<- prometheus.Metric) {
} }
func (t *testCounter) Describe(c chan<- *prometheus.Desc) { func (t *testCounter) Describe(_ chan<- *prometheus.Desc) {
} }
func (t *testCounter) Desc() *prometheus.Desc { func (t *testCounter) Desc() *prometheus.Desc {
return nil return nil
@ -156,6 +191,6 @@ func (t *testCounter) Desc() *prometheus.Desc {
func (t *testCounter) Inc() { func (t *testCounter) Inc() {
t.count++ t.count++
} }
func (t *testCounter) Write(x *io_prometheus_client.Metric) error { func (t *testCounter) Write(_ *io_prometheus_client.Metric) error {
return nil return nil
} }